Fix for memory allocation check \ VOGONS

Fix for memory allocation check

Topic actions

First post, by realnc

Posted on 2020-05-03, 19:36

realnc Offline

Rank Oldbie

Rank: Oldbie
Posts: 574
Joined: 2010-10-13, 11:02

MEMORY::MEMORY(Section*) has a bug where it uses the throwing 'new' but then checks for null, which will actually never detect an allocation failure because an exception will be thrown. The attached patch fixes it.

Reply 1 of 3, by Dominus

Posted on 2020-05-04, 05:44

Dominus Offline

Rank DOSBox Moderator

Rank: DOSBox Moderator
Posts: 9154
Joined: 2002-10-03, 09:54
Location: Ludwigsburg

Moved to patches!

Windows 3.1x guide for DOSBox
60 seconds guide to DOSBox
DOSBox SVN snapshot for macOS (10.4-11.x ppc/intel 32/64bit) notarized for gatekeeper

Reply 2 of 3, by Qbix

Posted on 2020-05-05, 10:25

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11234
Joined: 2002-11-27, 14:50
Location: Fryslan

Not sure about which C++ version this is for.
It might be for a relative new one.

Water flows down the stream
How to ask questions the smart way!

Reply 3 of 3, by realnc

Posted on 2020-05-05, 11:39

realnc Offline

Rank Oldbie

Rank: Oldbie
Posts: 574
Joined: 2010-10-13, 11:02

Qbix wrote on 2020-05-05, 10:25:

Not sure about which C++ version this is for.
It might be for a relative new one.

No, it worked like that since the beginning. This is the C++ standard document from 2005 for example:

http://www.open-std.org/jtc1/sc22/wg21/docs/p … /2005/n1905.pdf

cppreference.com also always marks things as "C++11/14/17/20" for things that were added later to the language, and this one doesn't have such tag:

https://en.cppreference.com/w/cpp/memory/new/nothrow

Go to top of page Go to top of page

Back to DOSBox Patches