AUDIO - raw opl capture problem \ VOGONS

AUDIO - raw opl capture problem

Topic actions

First post, by NewRisingSun

Posted on 2014-01-19, 19:56

NewRisingSun Offline

Rank Oldbie

Rank: Oldbie
Posts: 906
Joined: 2005-09-02, 02:26

I noticed a possible mistake in adlib.cpp. Registers 0xB0..0xB8 are not captured in the initial register dump, possibly to not include any notes that are already sounding when capturing begins. If a game initializes registers 0xB6..0xB8 only once and then turns percussion notes on and off by writing to 0xBD without reinitializing 0xB6..0xB8, the high bits of the frequency number will not be played back properly. Zeliard is one such game, and as expected, .DRO captures from that game sound wrong in all playback programs; some drum notes will be inaudible.

Zeliard captures correctly after the following source patch:

1--- adlib.cpp.old	2013-01-15 12:10:04 +0000
2+++ adlib.cpp	2014-01-19 19:54:06 +0000
3@@ -227,10 +227,10 @@
4 		Bitu i, val;
5 		/* Check the registers to add */
6 		for (i=0;i<256;i++) {
7-			//Skip the note on entries
8-			if (i>=0xb0 && i<=0xb8) 
9-				continue;
10 			val = (*cache)[ i ];
11+			//Silence the note on entries
12+			if (i>=0xb0 && i<=0xb8) 
13+				val &= ~0x20;
14 			if (val) {
15 				AddWrite( i, val );
16 			}

This silences any notes that were active before capturing was started while preserving the upper bits of the frequency number.

Reply 1 of 4, by Qbix

Posted on 2014-01-22, 07:43

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11284
Joined: 2002-11-27, 14:50
Location: Fryslan

Moving to patches part.
It's an interesting problem that you are touching.

Water flows down the stream
How to ask questions the smart way!

Reply 2 of 4, by Malvineous

Posted on 2014-03-30, 03:38

Malvineous Offline

Rank Oldbie

Rank: Oldbie
Posts: 595
Joined: 2006-06-11, 02:24
Location: Brisbane, Australia

This is a good fix, it should help correct a few capture problems. I think however you should also zero out register 0xBD, bits 0-4 (i.e. val &= 0x1f) as well. This will prevent extra notes from sounding at the beginning of the capture in the event that rhythm mode is enabled, and rhythm notes are active at the moment the capture begins.

Reply 3 of 4, by NewRisingSun

Posted on 2014-04-03, 18:06

NewRisingSun Offline

Rank Oldbie

Rank: Oldbie
Posts: 906
Joined: 2005-09-02, 02:26

Added the silencing of percussion notes, the silencing of second register set notes, plus the clearing of the register cache upon initialization. Commander Keen 4-6 would not capture properly without this additional memset command (the second register set is filled with garbage data), though I have no idea why it has never been an issue with other games.

1--- adlib.cpp.old	2013-01-15 12:10:04 +0000
2+++ adlib.cpp	2014-04-03 18:05:11 +0000
3@@ -227,14 +227,17 @@
4 		Bitu i, val;
5 		/* Check the registers to add */
6 		for (i=0;i<256;i++) {
7-			//Skip the note on entries
8-			if (i>=0xb0 && i<=0xb8) 
9-				continue;
10 			val = (*cache)[ i ];
11+			//Silence the note on entries			
12+			if (i>=0xb0 && i<=0xb8) 
13+				val &= ~0x20;
14+			if (i==0xbd) val &= ~0x1f;
15 			if (val) {
16 				AddWrite( i, val );
17 			}
18 			val = (*cache)[ 0x100 + i ];
19+			if (i>=0xb0 && i<=0xb8) 
20+				val &= ~0x20;
21 			if (val) {
22 				AddWrite( 0x100 + i, val );
23 			}
24@@ -525,6 +528,7 @@
25 
26 void Module::Init( Mode m ) {
27 	mode = m;
28+	memset(cache, 0, 0x200);
29 	switch ( mode ) {
30 	case MODE_OPL3:
31 	case MODE_OPL2:
32

Reply 4 of 4, by Qbix

Posted on 2020-11-10, 15:36

Qbix Offline

Rank DOSBox Author

Rank: DOSBox Author
Posts: 11284
Joined: 2002-11-27, 14:50
Location: Fryslan

Added in 4392.

Water flows down the stream
How to ask questions the smart way!

Go to top of page Go to top of page

Back to DOSBox Patches